/ babel Public
test: add tests about behaviour of replaceWithMultiple #12309
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Add a test on the
NodePath#replaceWithMultiplebehaviour when one of node is the replaced node. This tests is required by #12302, I feel it should be landed separately.
This behaviour is not intuitive to me. It is not visited because in
Lines 46 to 52 in 12c6db6
when we clear
n, w.l.o.g. we assume
nodes === n), we don't update the
pathCacheof its parent.
Line 70 in 12c6db6
pathCacheholds a NodePath which has a reference to the
n, it implicitly copy
nto a new memory address. Now when the
nis queried against
Line 79 in 12c6db6
pathCacheis missed because the NodePath is referencing a shallow copy of
n, so a new NodePath instance is created for
Lines 53 to 59 in 12c6db6
then it is removed instead of
requeueso this node is never visited after replaced.
I think intuitively all nodes in the argument of
replaceWithMultipleshould be revisited. But the suggested behaviour is a breaking change, e.g. breaking TDZ implementation.