Fix support for polyfilling Array.prototype.values in core-js@2 #12340
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I was chatting with @hzoo about this since the comment goes back to when we first created
preset-env
... and it seems (???) like at the time we might have not included this in the features list fores6.array.iterator
because there were not any environments that implemented it at the time (?). But to be honest, not sure. I actually ran into a case within a codebase that used this andpreset-env
didn't include the polyfill properly.(Alternative is we can update the documentation to instruct people to
include: [es6.array.iterator]
if you're usingArray.prototype.values()
, but that definitely would be unexpected.)