Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not throw when creating type annotation based on bigint #12971

Merged
merged 4 commits into from Mar 19, 2021

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 5, 2021

Q                       A
Fixed Issues? Closes #12965, fixes #13018
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Mar 5, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44375/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Mar 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5eee3af:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
} else if (type === "bigint") {
// todo: use BigInt annotation when Flow supports BigInt
// https://github.com/facebook/flow/issues/6639
return anyTypeAnnotation();

This comment has been minimized.

@JLHwung

JLHwung Mar 5, 2021
Author Contributor

We can not use numberTypeAnnotation here because Math functions do not work with BigInt. Mark it as any as it is not supported in Flow.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

In the future we could consider moving away from Flow as an internal representation of types.

@JLHwung JLHwung merged commit 8596316 into babel:main Mar 19, 2021
25 of 27 checks passed
25 of 27 checks passed
@github-actions
Prepare Cache
Details
@github-actions
Test on Node.js Latest
Details
@github-actions
Build Babel Artifacts
Details
@github-actions
Test Babel 8 breaking changes
Details
@github-actions
Publish to local Verdaccio registry
Details
@github-actions
Lint
Details
@github-actions
Test on Node.js (14)
Details
@github-actions
Test on Node.js (12)
Details
@github-actions
Test on Node.js (10)
Details
@github-actions
Test on Node.js (8)
Details
@github-actions
Test on Node.js (6)
Details
@github-actions
Test on Windows
Details
@github-actions
Third-party Parser Tests
Details
@github-actions
Test @babel/runtime integrations
Details
@github-actions
E2E (babel)
Details
@github-actions
E2E (babel-old-version)
Details
@github-actions
E2E (create-react-app)
Details
@github-actions
E2E (vue-cli)
Details
@github-actions
E2E (jest)
Details
@circleci-checks
e2e-breaking-pr Workflow: e2e-breaking-pr
Details
@circleci-checks
test262-pr Workflow: test262-pr
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@babel-bot
babel/repl REPL preview is available
Details
@circleci-checks
build-standalone Workflow: build-standalone
Details
@codesandbox
ci/codesandbox Building packages succeeded.
Details
@codecov
codecov/project 91.41% (target 90.00%)
Details
@circleci-checks
e2e Workflow: e2e
Details
@JLHwung JLHwung deleted the JLHwung:create-type-annotation-based-on-bigint branch Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants