Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point to CJS files in @babel/compat-data's exports #13000

Merged
merged 1 commit into from Mar 15, 2021

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 13, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

.json files cannot be imported in native ESM files (docs). Always pointing to the CJS proxies makes @babel/compat-data work both with require() and import.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Mar 13, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44301/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Mar 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 45289dd:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@nicolo-ribaudo nicolo-ribaudo merged commit 759f8ec into babel:main Mar 15, 2021
25 of 27 checks passed
25 of 27 checks passed
@github-actions
Prepare Cache
Details
@github-actions
Test on Node.js Latest
Details
@github-actions
Build Babel Artifacts
Details
@github-actions
Test Babel 8 breaking changes
Details
@github-actions
Publish to local Verdaccio registry
Details
@github-actions
Lint
Details
@github-actions
Test on Node.js (14)
Details
@github-actions
Test on Node.js (12)
Details
@github-actions
Test on Node.js (10)
Details
@github-actions
Test on Node.js (8)
Details
@github-actions
Test on Node.js (6)
Details
@github-actions
Test on Windows
Details
@github-actions
Third-party Parser Tests
Details
@github-actions
Test @babel/runtime integrations
Details
@github-actions
E2E (babel)
Details
@github-actions
E2E (babel-old-version)
Details
@github-actions
E2E (create-react-app)
Details
@github-actions
E2E (vue-cli)
Details
@github-actions
E2E (jest)
Details
@circleci-checks
e2e-breaking-pr Workflow: e2e-breaking-pr
Details
@circleci-checks
test262-pr Workflow: test262-pr
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@babel-bot
babel/repl REPL preview is available
Details
@circleci-checks
build-standalone Workflow: build-standalone
Details
@codesandbox
ci/codesandbox Building packages succeeded.
Details
@codecov
codecov/project 91.41% (target 90.00%)
Details
@circleci-checks
e2e Workflow: e2e
Details
Move to native ES modules automation moved this from In progress to Done Mar 15, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:compat-data-exports branch Mar 15, 2021
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants