Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compat data #13008

Merged
merged 4 commits into from Mar 19, 2021
Merged

Update compat data #13008

merged 4 commits into from Mar 19, 2021

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Mar 16, 2021

Q                       A
Fixed Issues? The second step on fixing #13001
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This PR bumps compat-table and adds support data on the upcoming bugfix/transform-v8-spread-parameters-after-optional-chaining.

"samsung": "13",
"electron": "8.0"
},
"bugfix/transform-v8-spread-parameters-after-optional-chaining": {

This comment has been minimized.

@JLHwung

JLHwung Mar 16, 2021
Author Contributor

WDYT bugfix/v8-spread-parameters-after-optional-chaining? I can't think of any term other transform that could follow bugfix/.

This comment has been minimized.

@jridgewell

jridgewell Mar 16, 2021
Member

Nit: in, not after?

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Mar 16, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44368/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Mar 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d14eab4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
"samsung": "13",
"electron": "8.0"
},
"bugfix/transform-v8-spread-parameters-after-optional-chaining": {

This comment has been minimized.

@jridgewell

jridgewell Mar 16, 2021
Member

Nit: in, not after?

Copy link
Contributor Author

@JLHwung JLHwung left a comment

I think we should also bump private-methods as

new class { #m() {} constructor() { null?.#m(...[], 1) } }

also throws.

Or we transpile it to

new class { #m() {} constructor() { null == null ? undefined : null.#m(...[], 1) } }

so it is still good to assume v8 84 has full support of private methods.

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 19, 2021

@JLHwung In that case we should only transpile the optional chain, leaving private methods as-is.

@JLHwung JLHwung merged commit 020c88e into babel:main Mar 19, 2021
24 of 26 checks passed
24 of 26 checks passed
@github-actions
Prepare Cache
Details
@github-actions
Test on Node.js Latest
Details
@github-actions
Build Babel Artifacts
Details
@github-actions
Test Babel 8 breaking changes
Details
@github-actions
Publish to local Verdaccio registry
Details
@github-actions
Lint
Details
@github-actions
Test on Node.js (14)
Details
@github-actions
Test on Node.js (12)
Details
@github-actions
Test on Node.js (10)
Details
@github-actions
Test on Node.js (8)
Details
@github-actions
Test on Node.js (6)
Details
@github-actions
Test on Windows
Details
@github-actions
Third-party Parser Tests
Details
@github-actions
Test @babel/runtime integrations
Details
@github-actions
E2E (babel)
Details
@github-actions
E2E (babel-old-version)
Details
@github-actions
E2E (create-react-app)
Details
@github-actions
E2E (vue-cli)
Details
@github-actions
E2E (jest)
Details
@circleci-checks
e2e-breaking-pr Workflow: e2e-breaking-pr
Details
@circleci-checks
test262-pr Workflow: test262-pr
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@babel-bot
babel/repl REPL preview is available
Details
@circleci-checks
build-standalone Workflow: build-standalone
Details
@codesandbox
ci/codesandbox Building packages succeeded.
Details
@codecov
codecov/project 91.41% (target 90.00%)
Details
@JLHwung JLHwung deleted the JLHwung:update-compat-data branch Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants