Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lodash from babel-compat-data #13024

Merged
merged 2 commits into from Mar 19, 2021
Merged

Conversation

@jridgewell
Copy link
Member

@jridgewell jridgewell commented Mar 19, 2021

Re: #11726

@codesandbox
Copy link

@codesandbox codesandbox bot commented Mar 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 02fbf1b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Mar 19, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/44519/

return array.reduce((flattened, value) => {
return flattened.concat(value);
}, []);
}

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo Mar 19, 2021
Member

We could just bump the Node.js version requirement for building Babel to 12 (currently it's 10 I think), and avoid the polyfill.

This comment has been minimized.

@armano2

armano2 Mar 19, 2021
Contributor

that will be a breaking change, wdyt about doing this for babel8?

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo Mar 19, 2021
Member

It's not a breaking change, it's just the minimum Node.js versions used when building Babel (it doesn't affect the code published on npm, which is subject to semver).

This comment has been minimized.

@nicolo-ribaudo

nicolo-ribaudo Mar 19, 2021
Member

Actually, the minimum Node.js version is already 12 since many scripts we use are native ES modules. We can remove the polyfill without problems.

This comment has been minimized.

@jridgewell

jridgewell Mar 19, 2021
Author Member

That's good, because I forgot to call cb in this polyfill….. 😅

@nicolo-ribaudo nicolo-ribaudo merged commit 2b11748 into babel:main Mar 19, 2021
24 of 26 checks passed
24 of 26 checks passed
@github-actions
Prepare Cache
Details
@github-actions
Test on Node.js Latest
Details
@github-actions
Build Babel Artifacts
Details
@github-actions
Test Babel 8 breaking changes
Details
@github-actions
Publish to local Verdaccio registry
Details
@github-actions
Lint
Details
@github-actions
Test on Node.js (14)
Details
@github-actions
Test on Node.js (12)
Details
@github-actions
Test on Node.js (10)
Details
@github-actions
Test on Node.js (8)
Details
@github-actions
Test on Node.js (6)
Details
@github-actions
Test on Windows
Details
@github-actions
Third-party Parser Tests
Details
@github-actions
Test @babel/runtime integrations
Details
@github-actions
E2E (babel)
Details
@github-actions
E2E (babel-old-version)
Details
@github-actions
E2E (create-react-app)
Details
@github-actions
E2E (vue-cli)
Details
@github-actions
E2E (jest)
Details
@circleci-checks
e2e-breaking-pr Workflow: e2e-breaking-pr
Details
@circleci-checks
test262-pr Workflow: test262-pr
Details
@gitpod-io
Gitpod Open an online workspace in Gitpod
Details
@babel-bot
babel/repl REPL preview is available
Details
@circleci-checks
build-standalone Workflow: build-standalone
Details
@codesandbox
ci/codesandbox Building packages succeeded.
Details
@codecov
codecov/project 91.45% (target 90.00%)
Details
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants