Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typeParameters to tagged template visitor keys #13500

Merged
merged 4 commits into from Jun 22, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 22, 2021

Q                       A
Fixed Issues? Fixes #13492
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: types labels Jun 22, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 22, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47055/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 22, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0db9957:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

nicolo-ribaudo
nicolo-ribaudo previously approved these changes Jun 22, 2021
@nicolo-ribaudo nicolo-ribaudo dismissed their stale review Jun 22, 2021

Uh it looks like I was wrong, it's builder that inherits from visitor and visitor defaults to an empty array 😅

@JLHwung JLHwung force-pushed the type-parameters-visitor branch from 3e7c299 to c080d9e Compare Jun 22, 2021
});

defineType("ClassPrivateProperty", {
visitor: ["key", "value", "decorators", "typeAnnotation"],
Copy link
Contributor Author

@JLHwung JLHwung Jun 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added "typeAnnotation" to visitor keys.

@JLHwung JLHwung merged commit 3840893 into babel:main Jun 22, 2021
25 of 27 checks passed
@JLHwung JLHwung deleted the type-parameters-visitor branch Jun 22, 2021
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
* refactor: move ES2022 AST nodes to core

* fix: add typeParameters to visitor keys

* chore: update artifacts

* fix: add typeAnnotation to visitor keys
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 22, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: should "typeParameters" be a visitor-name of TaggedTemplateExpression ?
4 participants