Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config validation message typo #13515

Merged
merged 2 commits into from Jun 29, 2021

Conversation

jaeseokk
Copy link
Contributor

@jaeseokk jaeseokk commented Jun 28, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Fixed config option names in validation message preset/plugin -> presets/plugins.

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 28, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47135/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8d5987:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Good catch!

[\\"./fixtures/option-manager/babel-preset-bar\\", {
\\"useSpread\\": true
}]
]
To be a valid preset, its name and options should be wrapped in a pair of brackets"
To be a valid presets, its name and options should be wrapped in a pair of brackets"
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Jun 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it's better not to have the s here. Maybe you could edit the checkNoUnwrappedItemOptionPairs adding the s for the "Maybe you meant to use" section, rather than changing it in the parameter?

Copy link
Contributor Author

@jaeseokk jaeseokk Jun 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!
I fixed it as you said.

b8d5987

@nicolo-ribaudo nicolo-ribaudo added area: errors PR: Polish 💅 A type of pull request used for our changelog categories labels Jun 28, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 6df0b7c into babel:main Jun 29, 2021
25 of 27 checks passed
@jaeseokk jaeseokk deleted the config-validation-message-typo branch Jun 29, 2021
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
* Fix config validation message typo

* Fix `checkNoUnwrappedItemOptionPairs` type param
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants