Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvement to gulp generate-runtime-helpers error message #13522

Merged
merged 2 commits into from Jul 2, 2021

Conversation

lightmare
Copy link
Contributor

@lightmare lightmare commented Jun 30, 2021

Q                       A
Fixed Issues? n/a
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? none added
Documentation PR Link
Any Dependency Changes?
License MIT

generate-helpers.js failed with an unhelpful TypeError if it couldn't find a minVersion in some file under src/helpers/. I had some (hidden) vim swap files in there and it was quite baffling. So after adding a more informative message I also made it ignore dotfiles.

lightmare added 2 commits Jun 30, 2021
If you had some garbage in packages/babel-runtime-helpers/src/helpers/,
gulp generate-runtime-helpers would blow up with an unhelpful message:

    TypeError: Cannot read property 'groups' of null
@babel-bot
Copy link
Collaborator

babel-bot commented Jun 30, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47153/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit daa02c8:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thanks!

JLHwung
JLHwung approved these changes Jul 2, 2021
@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 2, 2021
@JLHwung JLHwung merged commit 4ee78eb into babel:main Jul 2, 2021
25 of 27 checks passed
@lightmare lightmare deleted the better-gulp-error-message branch Jul 7, 2021
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
…el#13522)

* improve gulp generate-runtime-helpers error message

If you had some garbage in packages/babel-runtime-helpers/src/helpers/,
gulp generate-runtime-helpers would blow up with an unhelpful message:

    TypeError: Cannot read property 'groups' of null

* ignore files starting with a dot when generating runtime helpers
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants