Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel-types): accept UnaryExpression in TSLiteralType #13525

Merged
merged 3 commits into from Jul 2, 2021

Conversation

@colinaaa
Copy link
Contributor

@colinaaa colinaaa commented Jul 2, 2021

Q                       A
Fixed Issues? Fixes #13327
Patch: Bug Fix? 👍
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Add validator for TSLiteralType to accept UnaryExpression

eg:

type A = -1 | 1;

…ession

seems that the generated files is missing typings

fix #13327
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Jul 2, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47181/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jul 2, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9c5a677:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

now generated types seems correct
@colinaaa colinaaa requested a review from JLHwung Jul 2, 2021
@JLHwung
JLHwung approved these changes Jul 2, 2021
Copy link
Contributor

@JLHwung JLHwung left a comment

Thanks!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thank you!

@nicolo-ribaudo nicolo-ribaudo changed the title fix(babel-types): add validator for TSLiteralType to accept UnaryExpression fix(babel-types): accept UnaryExpression in TSLiteralType Jul 2, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit fce35af into babel:main Jul 2, 2021
24 of 26 checks passed
24 of 26 checks passed
@github-actions
Prepare Cache
Details
@github-actions
Validate Yarn dependencies and constraints
Details
@github-actions
Test on Node.js Latest
Details
@github-actions
Build Babel Artifacts
Details
@github-actions
Test Babel 8 breaking changes
Details
@github-actions
Publish to local Verdaccio registry
Details
@github-actions
Lint
Details
@github-actions
Test on Node.js (14)
Details
@github-actions
Test on Node.js (12)
Details
@github-actions
Test on Node.js (10)
Details
@github-actions
Test on Node.js (8)
Details
@github-actions
Test on Node.js (6)
Details
@github-actions
Test on Windows
Details
@github-actions
Third-party Parser Tests
Details
@github-actions
Test @babel/runtime integrations
Details
@github-actions
E2E (babel)
Details
@github-actions
E2E (babel-old-version)
Details
@github-actions
E2E (create-react-app)
Details
@github-actions
E2E (vue-cli)
Details
@github-actions
E2E (jest)
Details
@circleci-checks
e2e-breaking-pr Workflow: e2e-breaking-pr
Details
@circleci-checks
test262-pr Workflow: test262-pr
Details
@babel-bot
babel/repl REPL preview is available
Details
@circleci-checks
build-standalone Workflow: build-standalone
Details
@codesandbox
ci/codesandbox Building packages succeeded.
Details
@codecov
codecov/project 92.04% (target 90.00%)
Details
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
…13525)

* fix(babel-types): add validator for TSLiteralType to accept UnaryExpression

seems that the generated files is missing typings

fix babel#13327

* fix(babel-types): add allowlist for TSLiteralType

now generated types seems correct

* fix(babel-types): use oneOfNodeTypes instead of oneOf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants