Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow reinitializing private elements #13601

Merged
merged 33 commits into from Aug 30, 2021

Conversation

@komyg
Copy link
Contributor

@komyg komyg commented Jul 26, 2021

Q                       A
Fixed Issues? Fixes #13299
Patch: Bug Fix
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No
Documentation PR Link
Any Dependency Changes? No
License MIT

@komyg komyg changed the title Fix/bug 13299 class members Fix 13299 Jul 26, 2021
@jridgewell jridgewell changed the title Fix 13299 Fix reinitialized private field Jul 26, 2021
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Jul 26, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48244/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Jul 26, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ebf193c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved
packages/babel-helpers/src/helpers.js Outdated Show resolved Hide resolved
@colinaaa
Copy link
Contributor

@colinaaa colinaaa commented Aug 3, 2021

Since #13570 has been merged, you probably need to rebase to main and write code with typings

@komyg
Copy link
Contributor Author

@komyg komyg commented Aug 5, 2021

Since #13570 has been merged, you probably need to rebase to main and write code with typings

Done!

Thank you for the typings by the way. They will be very hepful.

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 7, 2021

Can you run OVERWRITE=true yarn jest or OVERWRITE=true make test?

@komyg
Copy link
Contributor Author

@komyg komyg commented Aug 7, 2021

Can you run OVERWRITE=true yarn jest or OVERWRITE=true make test?

Done.

I've pushed all the snapshot changes.

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 11, 2021

The CI failure would be fixed by rebasing; don't worry about it.

@komyg komyg marked this pull request as ready for review Aug 12, 2021
@komyg komyg requested a review from nicolo-ribaudo Aug 16, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thanks!

komyg and others added 4 commits Aug 18, 2021
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
@komyg
Copy link
Contributor Author

@komyg komyg commented Aug 18, 2021

Hi @nicolo-ribaudo, @jridgewell, @JLHwung and @colinaaa, I've incorporated all of your suggestions and added the latest changes from the main branch.

Would you like to re-review it?

Copy link
Member

@jridgewell jridgewell left a comment

LGTM, thanks for working on this!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thank you!

@nicolo-ribaudo nicolo-ribaudo changed the title Fix reinitialized private field Disallow reinitializing private elements Aug 30, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit fdfe978 into babel:main Aug 30, 2021
26 of 28 checks passed
@komyg komyg deleted the fix/bug-13299-class-members branch Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

6 participants