Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass browserslistEnv to resolveTargets #13697

Merged
merged 1 commit into from Aug 30, 2021

Conversation

@meskill
Copy link
Contributor

@meskill meskill commented Aug 20, 2021

Q                       A
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Any Dependency Changes? No
License MIT

In case of explicitly specifying browserslist query with extends keyword, browserslistEnv option was not passed to browserslist itself leading to wrong resolved targets

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Aug 20, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48313/

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8b67ba:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@meskill meskill force-pushed the fix/pass-browserslistenv branch from 62eb2f1 to a84b13a Aug 20, 2021
jest.config.js Outdated Show resolved Hide resolved
fedeci
fedeci approved these changes Aug 23, 2021
Copy link
Member

@fedeci fedeci left a comment

Thanks!

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thank you!

I usually ask to not commit changes to .gitignore since you can use .git/info/exclude instead. However, since this also needs change in the Jest config and since that extension looks useful (I might use it!), it's ok this time.

@nicolo-ribaudo nicolo-ribaudo changed the title fix: pass browserslistEnv to resolveTargets fix: pass browserslistEnv to resolveTargets Aug 30, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit cb3ebde into babel:main Aug 30, 2021
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants