Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[babel 8] fix: stricter rest element builder check #13715

Merged
merged 1 commit into from Aug 31, 2021

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 30, 2021

Q                       A
Fixed Issues? When BABEL_TYPES_8_BREAKING is enabled, the RestElement constructor incorrectly allows AssignmentPattern as argument
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Per https://tc39.es/ecma262/#prod-BindingPattern, a binding pattern can only be either ArrayPattern or ObjectPattern.

@codesandbox
Copy link

@codesandbox codesandbox bot commented Aug 30, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 99d6bf9:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Aug 30, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48392/

fedeci
fedeci approved these changes Aug 30, 2021
@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 30, 2021

The CI failure is unrelated. I'm running the e2e-breaking tests.

@nicolo-ribaudo nicolo-ribaudo changed the title fix: stricter rest element builder check [babel 8] fix: stricter rest element builder check Aug 30, 2021
@JLHwung JLHwung merged commit 6436733 into babel:main Aug 31, 2021
25 of 27 checks passed
@JLHwung JLHwung deleted the stricter-rest-element-check branch Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants