Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caret topic (pipe operator) #13749

Merged
merged 6 commits into from Oct 28, 2021
Merged

Caret topic (pipe operator) #13749

merged 6 commits into from Oct 28, 2021

Conversation

@js-choi
Copy link
Contributor

@js-choi js-choi commented Sep 11, 2021

Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link babel/website#2575
Any Dependency Changes? No
License MIT

Adds option for "topicToken": "^" to the Hack pipe operator to match the current proposal. See tc39/proposal-pipeline-operator#91 (comment).

(This also fixes babel-generator only supporting "topicToken": "#" and not "topicToken": "%".)

CC @nicolo-ribaudo, @JLHwung, @tabatkins, @mAAdhaTTah, @jamiebuilds.

@codesandbox
Copy link

@codesandbox codesandbox bot commented Sep 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c422321:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

js-choi added a commit to tc39/proposal-pipeline-operator that referenced this issue Oct 16, 2021
As per #91 (comment), I think my [change of the spec from `%` to `^`](#91 (comment)) was premature, partially because I now mildly prefer `%` again, but mostly because it’s what we presented to plenary on August and because it’s what Babel currently supports (see babel/babel#13749).

This is a tentative change and has no bearing on what the actual final topic token will be. It’s just a swap to the explainer and spec back to what we presented to the Committee plenary on August.

This will be almost certainly be the last time I switch the topic token until we hold our TC39 incubator sessions for bikeshedding the token in early November.
Copy link
Contributor

@JLHwung JLHwung left a comment

Awesome!

@JLHwung JLHwung merged commit ad59a2c into babel:main Oct 28, 2021
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants