Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't transform declare class in plugin-proposal-class-properties #13854

Conversation

@forivall
Copy link
Contributor

@forivall forivall commented Oct 16, 2021

Q                       A
Fixed Issues? Fixes #13853
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Not yet
Documentation PR Link
Any Dependency Changes? No
License MIT

In the Class visitor,

  if (path.node.declare) return;

has been added.

Also some typescript improvements in the typescript transform.

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 16, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9578e3e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 16, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49238/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

I don't like that we throw an error, but plugin ordering is the hardest part of Babel's architecture so 🤷

@nicolo-ribaudo nicolo-ribaudo merged commit fca5c9a into babel:main Oct 20, 2021
26 of 28 checks passed
@forivall
Copy link
Contributor Author

@forivall forivall commented Oct 22, 2021

@nicolo-ribaudo yeah, I struggled with figuring out how to get the plugin ordering just right and i've left a note: #13853 (comment) . Hopefully a future version of babel can manage plugin+preset ordering in a better way. Maybe something as simple as printing the effective config when an error like this is thrown.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants