Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow enum member without initializer after non-literal member #13865

Merged
merged 2 commits into from Oct 22, 2021

Conversation

@lightmare
Copy link
Contributor

@lightmare lightmare commented Oct 20, 2021

Q                       A
Fixed Issues? Fixes #13863
Patch: Bug Fix? ✔️
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@codesandbox
Copy link

@codesandbox codesandbox bot commented Oct 20, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7669065:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Oct 20, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49314/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thanks!

@@ -108,37 +108,43 @@ export function translateEnumValues(
): Array<[name: string, value: t.Expression]> {
const seen: PreviousEnumMembers = Object.create(null);
Copy link
Contributor

@JLHwung JLHwung Oct 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can you also refactor seen into a Map?

Copy link
Contributor Author

@lightmare lightmare Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@JLHwung JLHwung merged commit cfe6739 into babel:main Oct 22, 2021
27 of 29 checks passed
@lightmare lightmare deleted the fix-transform-typescript-enum branch Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants