Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check preceding line break before exclamation #14049

Merged
merged 1 commit into from Dec 16, 2021
Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Dec 13, 2021

Q                       A
Fixed Issues? Fixes #14045
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The variable declaration disallows preceding line breaks before exclamation marks. See also https://github.com/microsoft/TypeScript/blob/67872a50d071ced53c1be6a8c03c9c3610584b4c/src/compiler/parser.ts#L6567

@JLHwung JLHwung added PR: Spec Compliance 👓 pkg: parser area: typescript labels Dec 13, 2021
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Dec 13, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50355/

@JLHwung JLHwung merged commit ad17fe1 into babel:main Dec 16, 2021
26 of 27 checks passed
@JLHwung JLHwung deleted the fix-14045 branch Dec 16, 2021
@github-actions github-actions bot added the outdated label Apr 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated pkg: parser PR: Spec Compliance 👓
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants