Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow $schema property in json config files #14067

Merged
merged 2 commits into from Dec 29, 2021

Conversation

The-x-Theorist
Copy link
Contributor

@The-x-Theorist The-x-Theorist commented Dec 20, 2021

Q                       A
Fixed Issues? Fixes #14038
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

$schema property will be deleted from json config files, while file is being read.

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Dec 20, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50436/

@nicolo-ribaudo nicolo-ribaudo changed the title Fix: Error on property in json config files Allow $schema property in json config files Dec 20, 2021
@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 💅 label Dec 20, 2021
Copy link
Contributor

@JLHwung JLHwung left a comment

Thanks!

@JLHwung JLHwung merged commit 2c68d03 into babel:main Dec 29, 2021
26 of 27 checks passed
@The-x-Theorist The-x-Theorist deleted the schema-property-json-config branch Dec 29, 2021
@github-actions github-actions bot added the outdated label Apr 5, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR: Polish 💅
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants