Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable "Reentrant plugin detected" error in async mode #14153

Merged
merged 1 commit into from Jan 14, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jan 14, 2022

Q                       A
Fixed Issues? Fixes #14148
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
  • this isn't a problem that can happen when running Babel asynchronously (because @babel/register runs it synchronously when it's in the same thread), and the error is buggy in this case
  • In Babel 8 we can completely remove the error, since thanks to #14025 @babel/register doesn't have this problem anymore.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 pkg: core labels Jan 14, 2022
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented Jan 14, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50723/

@nicolo-ribaudo nicolo-ribaudo added this to In progress in Move to native ES modules via automation Jan 14, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit 8035ad9 into babel:main Jan 14, 2022
27 of 28 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the fix-14148 branch Jan 14, 2022
Move to native ES modules automation moved this from In progress to Done Jan 14, 2022
@github-actions github-actions bot added the outdated label Apr 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated pkg: core PR: Bug Fix 🐛
Development

Successfully merging this pull request may close these issues.

4 participants