Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print necessary parentheses for functions in postfix expressions #14532

Merged
merged 1 commit into from May 6, 2022

Conversation

xiawenqi
Copy link
Contributor

@xiawenqi xiawenqi commented May 6, 2022

Q                       A
Fixed Issues? Fixes #14401
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

fix the problem (function (){}).x++ doesn't correctly generate parentheses, previously generate function () { return {x: 24} }().x++;

@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented May 6, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51861/

1 similar comment
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented May 6, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51861/

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 pkg: generator labels May 6, 2022
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thank you! The ci failure is not related.

JLHwung
JLHwung approved these changes May 6, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit 0984a2a into babel:main May 6, 2022
33 of 35 checks passed
@nicolo-ribaudo nicolo-ribaudo changed the title fix: isFirstInContext doesn't handle postfix unary operators Print necessary parentheses for functions in postfix expressions May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: generator PR: Bug Fix 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants