Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import-assertions to shippedProposals #14556

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 16, 2022

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The import assertions proposal has been shipped in Chrome 91 and Node.js 17.1. Therefore we should add the syntax plugin to shippedProposals.

@JLHwung JLHwung added the PR: New Feature 🚀 label May 16, 2022
@babel-bot
Copy link
Collaborator

@babel-bot babel-bot commented May 16, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51945/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Can you add a test? We didn't have any more "shipped proposal" plugins, so all the tests had been disabled.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.18.0 milestone May 17, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit e57d081 into babel:main May 19, 2022
35 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the add-import-assertions-to-shipped-proposals branch May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: preset-env PR: New Feature 🚀 Spec: Import Assertions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants