Fix: Test exception when using global yarn3

[liuxingbaoyu]

Q	A
Fixed Issues?	Test exception when using global yarn3
Patch: Bug Fix?	√
Major: Breaking Change?	×
Minor: New Feature?	×
Tests Added + Pass?	×
Documentation PR Link
Any Dependency Changes?
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52447/

[nicolo-ribaudo]

Isn't this just like npx? i.e. it doesn't make the package globally available; it just executes it.

[liuxingbaoyu]

Yes, the global install was removed in yarn3.

[merceyz]

@nicolo-ribaudo Correct, in this case it will download verdaccio-memory and look for a binary with the same name, it wont be able to locate one and throw.

[nicolo-ribaudo]

This PR does not do what you think it does.

What we need is that Yarn should install verdaccio-memory and make it globally available, so that verdaccio can then use it. What this PR does is that it tries to execute verdaccio-memory (and as mentioned by @merceyz it fails), without installing it.

I don't remember why we need verdaccio-memory, maybe @juanpicado knows? (it originally came from juanpicado#1)

[merceyz]

@nicolo-ribaudo Instead of using nohup npx have you (the Babel team) considered using the docker container instead?

[nicolo-ribaudo]

The main reason is that I have almost zero docker experience and I thus I didn't think about it 😛
If someone wants to update our e2e tests to use docker (either some from the team, or external) I'd be really happy about that because it also makes it easier to run them locally.

[liuxingbaoyu]

I will try to research it. (Probably not docker though, since it's not particularly convenient on Windows, and also feels like it might be a bit slow in CI)

[juanpicado]

This PR does not do what you think it does.

What we need is that Yarn should install verdaccio-memory and make it globally available, so that verdaccio can then use it. What this PR does is that it tries to execute verdaccio-memory (and as mentioned by @merceyz it fails), without installing it.

I don't remember why we need verdaccio-memory, maybe @juanpicado knows? (it originally came from juanpicado#1)

I think you are not using it https://github.com/babel/babel/blob/main/scripts/integration-tests/verdaccio-config.yml#L9 so I guess it's safe to be removed. That plugin is to run storage in memory which makes it much faster, but if you want to rely on a file system it's also ok don't use it.

If you were using it, the storage: ./some-path won't be used.

[liuxingbaoyu]

I'm not sure if it's working, but it should be able to be removed without much impact.

https://github.com/liuxingbaoyu/babel/runs/7231597398?check_suite_focus=true

In e2e-publish, the time increased by half a minute - 1 minute, and the overall CI speed did not change much.

renew:

https://github.com/liuxingbaoyu/babel/runs/7231916640?check_suite_focus=true

It can be seen from this that there will be no impact.

[liuxingbaoyu]

Closing this as it was erroneously included in https://github.com/babel/babel/pull/14701.😰