Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable noImplicitAny #14601

Merged
merged 22 commits into from Jun 21, 2022
Merged

enable noImplicitAny #14601

merged 22 commits into from Jun 21, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 26, 2022

Q                       A
License MIT

This is a meta PR tracking the progress of the noImplicitAny option adoption. I will mark the PR as ready when CI is green.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label May 26, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented May 26, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52321/

@liuxingbaoyu
Copy link
Contributor

liuxingbaoyu commented May 30, 2022

@JLHwung Are you writing babel-template and babel-core, if not I would like to give it a try.

@@ -25,7 +25,7 @@
},
"dependencies": {
"@babel/helper-validator-identifier": "workspace:^",
"to-fast-properties": "^2.0.0"
"to-fast-properties": "condition:BABEL_8_BREAKING ? ^4.0.0 : ^2.0.0"
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Jun 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4 is native ESM, that we can't use yet because we compile to CJS. We should downgrade to v3.

Copy link
Contributor Author

@JLHwung JLHwung Jun 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Aren't we gonna make Babel 8 ESM-only?

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Jun 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it's not ready yet so the current Babel 8 build fails with this PR 😛

We will be able to upgrade before Babel 8.0.0, but not yet.

@JLHwung JLHwung force-pushed the noImplicitAny branch 2 times, most recently from bceef21 to 18291cb Compare Jun 21, 2022
JLHwung and others added 20 commits Jun 21, 2022
* preset-typescript

* transform-typescript

* Update packages/babel-plugin-transform-typescript/src/enum.ts

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* prettier

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* enable noImplicitAny

* codemod (#14602)

* Improve preset/plugin-typescript typings (#14603)

* preset-typescript

* transform-typescript

* Update packages/babel-plugin-transform-typescript/src/enum.ts

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* prettier

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* improve transform-runtime typings

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* improve helper-function-name typings

* helper hoist variables

* helper-member-expression-to-functions

* helper-simple-access

* remap-async-to-generator

* helper-annotate-as-pure

* helper-builder-binary-assignment-operator-visitor

* helper-check-duplicate-nodes

* early return when export declaration is export all

* split-export-declaration

* helper-define-map

* define-map

* Update packages/babel-helper-builder-binary-assignment-operator-visitor/src/index.ts

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

* review comments

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* refactor: simplify ImportInjector._applyDefaults

* helper-module-imports

* map globals to the one used in Babel 8
* plugin-test-runner

* fixture-test-runner

* Update packages/babel-helper-fixtures/src/index.ts

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* refactor: move shipped-proposals to ts

* preset-env

* address review comments
* refactor: simplify buildOptimizedSequenceExpression

* proposal-pipeline-operator

* address review comments
* babel-standalone

* address review comment
* change AssumptionFunction return type

* helper-create-regexp-features-plugin

* create-class-features-plugin

* transform-for-of

* improve unicode-escapes typings

* transform-object-super

* transform-react-constant-elements

* proto-to-assign

* function-name

* flow-comments

TS cannot infer Flow visitor type because we have both Flow type and Flow virtual type.
* code-frame

* map js-tokens to Babel 8

* highlight
* bump to-fast-properties to v4

* types

* mark node comments as mutable
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
* generator

* refactor: merge {start,end}Terminatorless to printTerminatorless

* inline buildYieldAwait

* inline ExportDeclaration

* also export Pos

* let getPossibleRaw return string | void

* Apply suggestions from code review

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>

* address review comments

* do not export internal printer method

* simplify needsWhitespace

Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: liuxingbaoyu <30521560+liuxingbaoyu@users.noreply.github.com>
* exponentiation-operator

* duplicate-keys

* computed-properties

* replace-supers

* block-scoping

* block-scoped-functions

* syntax-typescript

* record-and-tuple

* private-property-in-object

* partial-application

* json-strings

* function-sent

* function-bind

* class-static-block

* async-generator-functions

* Update packages/babel-plugin-transform-block-scoping/src/index.ts

* address review comments

* helper-replace-supers
* external-helpers

* bugfix

* transform-parameters

* object-rest-spread

* destructuring-private

* transform-destructuring

* proposal-decorators

* optional-chaining

* helper-wrap-function

* explode-assignable-expression

* helper-compilation-targets

* helper-plugin-utils

* helpers

* helper-validator-option

* fix: allow "+" and "-" in MappedType .readonly/.optional

* fixture-test-runner

* remove charcodes from dependencies

the charcodes transform will inline charCodes.* so we can remove it from dependencies
* export removeProperties options

* traverse

* fix other packages typings

* fix gatherNodeParts

* downgrade to-fast-properties to v3

* fix typo

* babel-core/normalize-file

* add ignore comment property used by flow plugin

* refine getLastStatement typings

* fix babel-standalone rebase typing error

* fix assert.rejects polyfill

* simplify _param typings

* supress Babel 7 AST errors

* loosen defineType typings

The AST typings are generated from defineType calls, so defineType should accept a string as type.

* restore legacy code

* Suppress data/core-js-compat importing errors
@JLHwung JLHwung marked this pull request as ready for review Jun 21, 2022
@JLHwung JLHwung requested a review from nicolo-ribaudo Jun 21, 2022
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Disclaimer: I only reviewed this quickly, but I already reviewed all the commits in their PRs.

@JLHwung JLHwung merged commit b1e73d6 into main Jun 21, 2022
66 checks passed
@JLHwung JLHwung deleted the noImplicitAny branch Jun 21, 2022
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories umbrella ☂️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants