Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unshadow cjs exports when transforming mutations #14708

Merged
merged 2 commits into from Jun 29, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 29, 2022

Q                       A
Fixed Issues? Fixes #14628
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: modules labels Jun 29, 2022

function fn() {
exports.x = x = 3;
var _exports2 = 4;
Copy link
Member Author

@nicolo-ribaudo nicolo-ribaudo Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this PR, this was left as var exports = 4.

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 29, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52397/

@nicolo-ribaudo nicolo-ribaudo merged commit 1261051 into babel:main Jun 29, 2022
35 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the fix-14628 branch Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: modules PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants