Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deep clone shared AST field definitions #14737

Merged
merged 1 commit into from Jul 8, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 7, 2022

Q                       A
Fixed Issues? See below
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The shared AST field definitions could be mutated by

if (field.default !== undefined && builder.indexOf(key) === -1) {
field.optional = true;
}

This issue surfaced when I am reviewing https://github.com/babel/babel/pull/14730/files#diff-85c1fccaeecd3c19b928ca56b3730ba55d198ce4e61717f56fc6a6aa62a7f85fL1043, where the kind of ClassPrivateMethod changed from an optional property to a non-optional property (expected). Here we deep clone the shared definitions such that, for example, mutating TSPropertySignature's computed does not affect ClassMethod's.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 7, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52448/

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 8, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit 0d87fe7 into babel:main Jul 8, 2022
35 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the ast-types-misc-fix branch Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants