Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print a message when the watcher of babel-cli is ready. #14748

Merged
merged 1 commit into from Jul 10, 2022

Conversation

liuxingbaoyu
Copy link
Contributor

@liuxingbaoyu liuxingbaoyu commented Jul 9, 2022

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

I really hope this makes our CI stable.🙏

@liuxingbaoyu liuxingbaoyu added area: tests PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: cli labels Jul 9, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 9, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52471/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

I like this idea!

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories and removed PR: New Feature 🚀 A type of pull request used for our changelog categories labels Jul 10, 2022
@JLHwung
Copy link
Contributor

JLHwung commented Jul 10, 2022

I think emitting new progress message is more like a polish than a new feature.

@liuxingbaoyu
Copy link
Contributor Author

liuxingbaoyu commented Jul 10, 2022

Totally agree with this, thank you!

@liuxingbaoyu liuxingbaoyu changed the title feat: Print a message when the watcher of babel-cli is ready. Print a message when the watcher of babel-cli is ready. Jul 10, 2022
@liuxingbaoyu liuxingbaoyu merged commit ea99182 into babel:main Jul 10, 2022
35 checks passed
@liuxingbaoyu liuxingbaoyu deleted the try-fix-cli-ci branch Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests pkg: cli PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants