-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: TS declare class
in namespace should be removed
#14774
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52569/ |
f497498
to
afc6949
Compare
afc6949
to
799c0c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can you update the test to also cover enums, functions, and variables?
Ok,I’d like to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
declare class
in namespace should be removed
declare class
in namespace should be removeddeclare class
in namespace should be removed
For a concrete example, please see Issue, Declare class in namespace should not be assigned as a value after compilation.
Currently, babel-plugin-transform-typescript does not consider ClassDeclaration as a pure type.