Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TS declare class in namespace should be removed #14774

Merged
merged 3 commits into from Jul 20, 2022

Conversation

yimingjfe
Copy link
Contributor

@yimingjfe yimingjfe commented Jul 20, 2022

Q                       A
Fixed Issues? Fixes #14773
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

For a concrete example, please see Issue, Declare class in namespace should not be assigned as a value after compilation.

Currently, babel-plugin-transform-typescript does not consider ClassDeclaration as a pure type.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 20, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52569/

@yimingjfe yimingjfe force-pushed the namespace-declare-class branch from f497498 to afc6949 Compare Jul 20, 2022
@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Jul 20, 2022
@yimingjfe yimingjfe force-pushed the namespace-declare-class branch from afc6949 to 799c0c1 Compare Jul 20, 2022
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thank you! Can you update the test to also cover enums, functions, and variables?

@yimingjfe
Copy link
Contributor Author

yimingjfe commented Jul 20, 2022

Thank you! Can you update the test to also cover enums, functions, and variables?

Ok,I’d like to do it.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title fix: Declare class in namespace should be removed fix: declare class in namespace should be removed Jul 20, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit b58e35b into babel:main Jul 20, 2022
38 checks passed
@nicolo-ribaudo nicolo-ribaudo changed the title fix: declare class in namespace should be removed fix: TS declare class in namespace should be removed Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants