Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable typescript incremental builds #14790

Merged
merged 1 commit into from Jul 24, 2022
Merged

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Jul 23, 2022

this is to make running tsc locally faster
(for me it is almost 10x improvement - reducing it from 40 to around 4 seconds)

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

this is to make running tsc locally faster(for me it around 10x improvement shorting it from 40 to 4 seconds)
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 23, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52595/

@liuxingbaoyu
Copy link
Contributor

liuxingbaoyu commented Jul 23, 2022

May I ask what command are you using? We only seem to use tsc with make prepublish-build.

This PR looks good to me though.

@liuxingbaoyu liuxingbaoyu added PR: Internal 🏠 A type of pull request used for our changelog categories area: typescript labels Jul 23, 2022
@zxbodya
Copy link
Contributor Author

zxbodya commented Jul 23, 2022

May I ask what command are you using? We only seem to use tsc with make prepublish-build.

yarn tsc (and time yarn tsc to measure the time it takes)

Copy link
Contributor

@JLHwung JLHwung left a comment

Thanks.

@JLHwung JLHwung merged commit 6af3ba7 into babel:main Jul 24, 2022
38 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the ts-incremental-builds branch Jul 24, 2022
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 24, 2022

@liuxingbaoyu You can also run it locally with make tscheck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: typescript PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants