Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix position of errors in template literals after newlines #14798

Merged
merged 2 commits into from Jul 26, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 26, 2022

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This fixes a regression introduced in #14772 (the first commit shows the wrong behavior, the second one fixes it). We always need to carry around lineStart and curLine, because they are needed to compute the error position.

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jul 26, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 26, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52616/

@nicolo-ribaudo nicolo-ribaudo force-pushed the error-position-in-templates branch from 0d1b983 to cfadbfe Compare Jul 26, 2022
@tolmasky
Copy link
Contributor

tolmasky commented Jul 26, 2022

Does this happen to fix this? #14146

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jul 26, 2022

@tolmasky No, but I'll take a look at it since it feels related.

@nicolo-ribaudo nicolo-ribaudo merged commit b7e0945 into babel:main Jul 26, 2022
38 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the error-position-in-templates branch Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants