Handle multiple named groups in wrapRegExp replace() #15090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53281/ |
nicolo-ribaudo
added
the
PR: Bug Fix 
ptomato
force-pushed
the
dncg-fix-replace
branch
from
9246937
to
a57a73d
Compare
JLHwung
reviewed
Oct 28, 2022
Previously, the [Symbol.replace] implementation in BabelRegExp assumed that the groups object property values were only numbers. With the duplicate named capturing groups plugin, they can be arrays of numbers as well. In the case of a duplicate named capturing group, the replacement pattern $<name> can be replaced by the concatenation of the pattern indices that have that name: e.g., $1$2.
ptomato
force-pushed
the
dncg-fix-replace
branch
from
a57a73d
to
7968d4a
Compare
liuxingbaoyu
approved these changes
Oct 29, 2022
nicolo-ribaudo
approved these changes
Oct 29, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Previously, the [Symbol.replace] implementation in BabelRegExp assumed that the groups object property values were only numbers. With the duplicate named capturing groups plugin, they can be arrays of numbers as well.
In the case of a duplicate named capturing group, the replacement pattern
$<name>can be replaced by the concatenation of the pattern indices that have that name: e.g.,$1$2. The bug was that the arrays got stringified in replacement patterns, leading to replacement patterns like$1,2.