Avoid defineProperty when not needed #1830

Merged
merged 1 commit into from Jun 25, 2015

Projects

None yet

2 participants

@kpdecker
Contributor

This lets us use the fast path for most object literal assignments and then utilizes the defineProperty path when there is a chance that we could hit the setter issue described in #357.

10x performance boosts seen for the six-speed test case, going from 200k operations/sec to 2M ops/sec.

@kpdecker kpdecker Avoid defineProperty when not needed
This lets us use the fast path for most object literal assignments and then utilizes the defineProperty path when there is a chance that we could hit the setter issue described in #357.

10x performance boosts seen for the six-speed test case, going from 200k operations/sec to 2M ops/sec.
1d83ad6
@kittens kittens merged commit 619fbe4 into babel:master Jun 25, 2015

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@kittens
Member
kittens commented Jun 25, 2015

This is awesome, thank you!

@kpdecker kpdecker deleted the kpdecker:avoid-define-property branch Nov 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment