New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator print refactor #2210

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@forivall
Contributor

forivall commented Aug 13, 2015

This moves all of the printing parts of the code generator into the from the NodePrinter class to the CodeGenerator. I found the code around this rather confusing, since the control flow of printing constantly flip flops between the CodeGenerator and the NodePrinter, and there's a lot of printing in the CodeGenerator anyways, so there's no real clear separation of concerns in the first place. It seems like there was some refactoring going on, that was stopped halfway, and it's now in this confusing state, where NodePrinter doesn't really do much other than add an unneeded layer of indirection.

I'm fine if this gets rejected, in favour of moving more code printing into the NodePrinter.

kittens added a commit that referenced this pull request Oct 5, 2015

@kittens kittens closed this Oct 5, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment