Generator print refactor #2210
Closed
Generator print refactor #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmck
added a commit
that referenced
this pull request
Oct 5, 2015
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all of the printing parts of the code generator into the from the NodePrinter class to the CodeGenerator. I found the code around this rather confusing, since the control flow of printing constantly flip flops between the CodeGenerator and the NodePrinter, and there's a lot of printing in the CodeGenerator anyways, so there's no real clear separation of concerns in the first place. It seems like there was some refactoring going on, that was stopped halfway, and it's now in this confusing state, where NodePrinter doesn't really do much other than add an unneeded layer of indirection.
I'm fine if this gets rejected, in favour of moving more code printing into the NodePrinter.