New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include $$typeof on inlined React elements #2352

Merged
merged 2 commits into from Sep 10, 2015

Conversation

Projects
None yet
4 participants
@sophiebits
Contributor

sophiebits commented Sep 10, 2015

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Sep 10, 2015

Contributor

Did I do this right? Ideally this could be in a Babel release before the React 0.14 RC that we're planning to push out tomorrow. Sorry for the late notice.

Contributor

sophiebits commented Sep 10, 2015

Did I do this right? Ideally this could be in a Babel release before the React 0.14 RC that we're planning to push out tomorrow. Sorry for the late notice.

@kittens

This comment has been minimized.

Show comment
Hide comment
@kittens

kittens Sep 10, 2015

Member

All the tests here will need to be updated too. I can push out a new 5.x release just for this if you want. 5.x is feature frozen until Babel 6 but I guess this falls somewhere under the realm of a bug fix.

Member

kittens commented Sep 10, 2015

All the tests here will need to be updated too. I can push out a new 5.x release just for this if you want. 5.x is feature frozen until Babel 6 but I guess this falls somewhere under the realm of a bug fix.

sophiebits added a commit to sophiebits/babel that referenced this pull request Sep 10, 2015

Fix template loading when hidden files exist
This made debugging babel#2352 confusing
because I had some vim swap files so it didn't load any of the
templates. (I assume this was the original intention.)
@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Sep 10, 2015

Contributor

Fixed the quotes and the tests.

Contributor

sophiebits commented Sep 10, 2015

Fixed the quotes and the tests.

@@ -1,6 +1,9 @@
"use strict";
var _typeofReactElement = typeof Symbol === "function" && Symbol["for"] && Symbol["for"]("react.element") || 60103;

This comment has been minimized.

@sophiebits

sophiebits Sep 10, 2015

Contributor

Kinda unfortunate that we lose our hex speak here. :) Consider this an enhancement request to preserve hex literals by default?

@sophiebits

sophiebits Sep 10, 2015

Contributor

Kinda unfortunate that we lose our hex speak here. :) Consider this an enhancement request to preserve hex literals by default?

@@ -23,4 +27,4 @@ function render() {
return function () {
return _ref2;
};
}
}

This comment has been minimized.

@sophiebits

sophiebits Sep 10, 2015

Contributor

I just uncommented the fs.writeFileSync in the test runner to make these files but I can undo these whitespace changes if you care.

@sophiebits

sophiebits Sep 10, 2015

Contributor

I just uncommented the fs.writeFileSync in the test runner to make these files but I can undo these whitespace changes if you care.

This comment has been minimized.

@kittens

kittens Sep 10, 2015

Member

Nah it's all good. I should add a newline to the fs comment though to avoid it in the future.

@kittens

kittens Sep 10, 2015

Member

Nah it's all good. I should add a newline to the fs comment though to avoid it in the future.

@sebmarkbage

This comment has been minimized.

Show comment
Hide comment
@sebmarkbage

sebmarkbage Sep 10, 2015

We should make sure that the order is the same for the hidden class.

$$typeof, type, key, ref, props, _owner

sebmarkbage commented Sep 10, 2015

We should make sure that the order is the same for the hidden class.

$$typeof, type, key, ref, props, _owner

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Sep 10, 2015

Contributor

Yeah, okay. Pushed ^ as a separate commit.

Contributor

sophiebits commented Sep 10, 2015

Yeah, okay. Pushed ^ as a separate commit.

kittens added a commit that referenced this pull request Sep 10, 2015

Merge pull request #2352 from spicyj/jsx-xss
Include $$typeof on inlined React elements

@kittens kittens merged commit ade747e into babel:master Sep 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@kittens

This comment has been minimized.

Show comment
Hide comment
@kittens

kittens Sep 10, 2015

Member

Thanks @spicyj!

Member

kittens commented Sep 10, 2015

Thanks @spicyj!

@sophiebits

This comment has been minimized.

Show comment
Hide comment
@sophiebits

sophiebits Sep 10, 2015

Contributor

Thank you!

Contributor

sophiebits commented Sep 10, 2015

Thank you!

@kittens

This comment has been minimized.

Show comment
Hide comment
@kittens

kittens Sep 10, 2015

Member

Released as of 5.8.23

Member

kittens commented Sep 10, 2015

Released as of 5.8.23

@jmm

This comment has been minimized.

Show comment
Hide comment
@jmm

jmm Sep 11, 2015

Member

@sebmck Is that a typo (s/5.8.23/5.8.24/)? Also mentioned here: #2282 (comment)

Member

jmm commented Sep 11, 2015

@sebmck Is that a typo (s/5.8.23/5.8.24/)? Also mentioned here: #2282 (comment)

@kittens

This comment has been minimized.

Show comment
Hide comment
@kittens

kittens Sep 11, 2015

Member

Yeah, whoops.

Member

kittens commented Sep 11, 2015

Yeah, whoops.

@jmm

This comment has been minimized.

Show comment
Hide comment
@jmm

jmm Sep 11, 2015

Member

@sebmck I was just thinking it might make sense to update that in the comments so people don't get confused, but maybe it's not that important.

Member

jmm commented Sep 11, 2015

@sebmck I was just thinking it might make sense to update that in the comments so people don't get confused, but maybe it's not that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment