Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Guy Fieri from Babel's source code #3646

Merged
merged 1 commit into from Aug 15, 2016

Conversation

Projects
None yet
@jdan
Copy link
Contributor

jdan commented Aug 9, 2016

I brought you into this world, and I can take you out of it.

Revert "Merge pull request #3641 from babel/guy-fieri"
This reverts commit 033681a, reversing
changes made to a2d66c0.

I brought you into this world, and I can take you out.
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 9, 2016

Thank you 😸

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 9, 2016

All part of the plan - thanks for your first Babel PR!

@dudeOFprosper

This comment has been minimized.

Copy link

dudeOFprosper commented Aug 9, 2016

👎

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 9, 2016

Current coverage is 88.13% (diff: 100%)

No coverage report found for master at 033681a.

Powered by Codecov. Last update 033681a...7dabeb4

@hzoo hzoo added this to the Next Patch milestone Aug 9, 2016

@zloirock

This comment has been minimized.

Copy link
Member

zloirock commented Aug 9, 2016

Nope, I use it in my projects. It's breaking change and requires major bump.

@hzoo hzoo modified the milestones: Next Major, Next Patch Aug 9, 2016

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 9, 2016

Babel 7: remove Guy Fieri

@hzoo hzoo removed this from the Next Major milestone Aug 9, 2016

@robotmayo

This comment has been minimized.

Copy link

robotmayo commented Aug 9, 2016

This would break my code that relies on being taken to flavortown.

@JosephClay

This comment has been minimized.

Copy link

JosephClay commented Aug 9, 2016

Fairly certain that all my unit tests check for guy before proceeding.

@stevemao

This comment has been minimized.

Copy link
Contributor

stevemao commented Aug 9, 2016

No HELL please!

@kittens

This comment has been minimized.

Copy link
Contributor

kittens commented Aug 9, 2016

Joke pull requests are not appreciated. @jdan Thank you for your contribution but we cannot accept this as its a semver major version change.

@kittens kittens closed this Aug 9, 2016

@jamiebuilds

This comment has been minimized.

Copy link
Contributor

jamiebuilds commented Aug 10, 2016

👐
♨️
🎤

@azu azu referenced this pull request Aug 10, 2016

Closed

v6.13.3 changelog [skip ci] #3648

@hernandev

This comment has been minimized.

Copy link

hernandev commented Aug 10, 2016

I would never discover codecov.io but for this joke! thank you guys, keep the world funny!

@yupferris yupferris referenced this pull request Aug 15, 2016

Closed

Removed guy ascii art #3656

@hzoo hzoo referenced this pull request Aug 15, 2016

Merged

Internal: remove comments #3657

@hzoo hzoo reopened this Aug 15, 2016

@hzoo hzoo merged commit ca27cf1 into babel:master Aug 15, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project 88.13% remains the same compared to a2d66c0
Details
@kittens

This comment has been minimized.

Copy link
Contributor

kittens commented Aug 15, 2016

no fun allowed

@babel babel locked and limited conversation to collaborators Aug 15, 2016

@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented Aug 16, 2016

😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.