Skip to content

Remove Guy Fieri from Babel's source code - #3646

Merged
hzoo merged 1 commit into
babel:masterfrom
jdan:partys-over-go-home
Aug 15, 2016
Merged

Remove Guy Fieri from Babel's source code#3646
hzoo merged 1 commit into
babel:masterfrom
jdan:partys-over-go-home

Conversation

@jdan

@jdan jdan commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

I brought you into this world, and I can take you out of it.

@jdan
Revert "Merge pull request babel#3641 from babel/guy-fieri"
7dabeb4 
This reverts commit 033681a, reversing
changes made to a2d66c0.

I brought you into this world, and I can take you out.
@hzoo

hzoo commented Aug 9, 2016

Copy link
Copy Markdown
Member

Thank you 馃樃

@hzoo

hzoo commented Aug 9, 2016

Copy link
Copy Markdown
Member

All part of the plan - thanks for your first Babel PR!

@dudeOFprosper

dudeOFprosper commented Aug 9, 2016

Copy link
Copy Markdown

馃憥

@codecov-io

codecov-io commented Aug 9, 2016 •
edited
Loading

Copy link
Copy Markdown

Current coverage is 88.13% (diff: 100%)

No coverage report found for master at 033681a.

Powered by Codecov. Last update 033681a...7dabeb4

@hzoo hzoo added this to the Next Patch milestone Aug 9, 2016
@zloirock

zloirock commented Aug 9, 2016

Copy link
Copy Markdown
Member

Nope, I use it in my projects. It's breaking change and requires major bump.

@hzoo hzoo modified the milestones: Next Major, Next Patch Aug 9, 2016
@hzoo

hzoo commented Aug 9, 2016

Copy link
Copy Markdown
Member

Babel 7: remove Guy Fieri

@hzoo hzoo added PR: Breaking Change 馃挜 A type of pull request used for our changelog categories for next major release and removed PR: Breaking Change 馃挜 A type of pull request used for our changelog categories for next major release labels Aug 9, 2016
@hzoo hzoo removed this from the Next Major milestone Aug 9, 2016
@robotmayo

robotmayo commented Aug 9, 2016

Copy link
Copy Markdown

This would break my code that relies on being taken to flavortown.

@JosephClay

JosephClay commented Aug 9, 2016

Copy link
Copy Markdown

Fairly certain that all my unit tests check for guy before proceeding.

@stevemao

stevemao commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

No HELL please!

@sebmck

sebmck commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

Joke pull requests are not appreciated. @jdan Thank you for your contribution but we cannot accept this as its a semver major version change.

@sebmck sebmck closed this Aug 9, 2016
@jamiebuilds

jamiebuilds commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

馃憪
鈾笍
馃帳

@azu azu mentioned this pull request Aug 10, 2016
Closed
@hernandev

hernandev commented Aug 10, 2016

Copy link
Copy Markdown

I would never discover codecov.io but for this joke! thank you guys, keep the world funny!

@yupferris yupferris mentioned this pull request Aug 15, 2016
Closed
@hzoo hzoo mentioned this pull request Aug 15, 2016
Merged
@hzoo hzoo reopened this Aug 15, 2016
@hzoo
hzoo merged commit ca27cf1 into babel:master Aug 15, 2016
@sebmck

sebmck commented Aug 15, 2016

Copy link
Copy Markdown
Contributor

no fun allowed

@ultrafez ultrafez mentioned this pull request Aug 15, 2016
Closed
@babel babel locked and limited conversation to collaborators Aug 15, 2016
@hzoo

hzoo commented Aug 16, 2016

Copy link
Copy Markdown
Member

馃槃

@hzoo hzoo added the PR: Bug Fix 馃悰 A type of pull request used for our changelog categories label Aug 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

PR: Bug Fix 馃悰 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.