New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-preset-stage-2: Add transform-unicode-property-regex #3683

Merged
merged 1 commit into from Jan 20, 2017

Conversation

Projects
None yet
5 participants
@mathiasbynens
Contributor

mathiasbynens commented Aug 29, 2016

Note: This transform depends on regexpu-core which supports Node.js v4+ only. So, this patch is blocked by https://phabricator.babeljs.io/T7392 / #4315.


This enables the use of Unicode property escapes of the form \p{…} and \P{…} in regular expressions with the u flag enabled.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 14, 2017

Member

@mathiasbynens can you rebase again? looks like we changed the presets to be "es modules".

Should we just move the plugin into the repo (don't have to)?

Member

hzoo commented Jan 14, 2017

@mathiasbynens can you rebase again? looks like we changed the presets to be "es modules".

Should we just move the plugin into the repo (don't have to)?

@mathiasbynens mathiasbynens changed the title from babel-preset-stage-1: Add transform-unicode-property-regex to babel-preset-stage-2: Add transform-unicode-property-regex Jan 14, 2017

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Jan 14, 2017

Contributor

Rebased.

Should we just move the plugin into the repo (don't have to)?

I’d prefer to keep it under my own account for now, so I can more easily keep it in sync with the proposal.

Contributor

mathiasbynens commented Jan 14, 2017

Rebased.

Should we just move the plugin into the repo (don't have to)?

I’d prefer to keep it under my own account for now, so I can more easily keep it in sync with the proposal.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 14, 2017

Member

Cool all good with me. We are going to use "independent" mode in lerna going forward in Babel 7 which just means we can publish all modules individually so we can at least update all stage-x presets and proposal plugins when necessary (only reasonable).

Also we'll want to move these prs to point to the new 7.0 branch (we can do this too in the github interface)

Member

hzoo commented Jan 14, 2017

Cool all good with me. We are going to use "independent" mode in lerna going forward in Babel 7 which just means we can publish all modules individually so we can at least update all stage-x presets and proposal plugins when necessary (only reasonable).

Also we'll want to move these prs to point to the new 7.0 branch (we can do this too in the github interface)

@hzoo hzoo changed the base branch from master to 7.0 Jan 20, 2017

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 20, 2017

Member

Looks like you've already did a 2.0? Should we update to that here? (also merge conflict due to the package.json updates (sorry)

Member

hzoo commented Jan 20, 2017

Looks like you've already did a 2.0? Should we update to that here? (also merge conflict due to the package.json updates (sorry)

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 20, 2017

Current coverage is 89.61% (diff: 100%)

Merging #3683 into 7.0 will not change coverage

@@                7.0      #3683   diff @@
==========================================
  Files           200        200          
  Lines          9751       9751          
  Methods        1060       1060          
  Messages          0          0          
  Branches       2597       2597          
==========================================
  Hits           8738       8738          
  Misses         1013       1013          
  Partials          0          0          

Powered by Codecov. Last update 1aa7a2a...d7ec839

codecov-io commented Jan 20, 2017

Current coverage is 89.61% (diff: 100%)

Merging #3683 into 7.0 will not change coverage

@@                7.0      #3683   diff @@
==========================================
  Files           200        200          
  Lines          9751       9751          
  Methods        1060       1060          
  Messages          0          0          
  Branches       2597       2597          
==========================================
  Hits           8738       8738          
  Misses         1013       1013          
  Partials          0          0          

Powered by Codecov. Last update 1aa7a2a...d7ec839

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Jan 20, 2017

Contributor

Heh, how did that happen?

Contributor

mathiasbynens commented Jan 20, 2017

Heh, how did that happen?

@chicoxyzzy

This comment has been minimized.

Show comment
Hide comment
@chicoxyzzy

chicoxyzzy Jan 20, 2017

Member

looks like 7.0 was rebased interactively

Member

chicoxyzzy commented Jan 20, 2017

looks like 7.0 was rebased interactively

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Jan 20, 2017

Contributor

@hzoo Updated to v2.0.0 and resolved the merge conflicts.

Contributor

mathiasbynens commented Jan 20, 2017

@hzoo Updated to v2.0.0 and resolved the merge conflicts.

import transformClassProperties from "babel-plugin-transform-class-properties";
import transformDecorators from "babel-plugin-transform-decorators";
import syntaxDynamicImport from "babel-plugin-syntax-dynamic-import";
import transformUnicodePropertyRegex from "babel-plugin-transform-unicode-property-regex";

This comment has been minimized.

@mathiasbynens

mathiasbynens Jan 20, 2017

Contributor

Sorted alphabetically (matching package.json)

@mathiasbynens

mathiasbynens Jan 20, 2017

Contributor

Sorted alphabetically (matching package.json)

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Jan 20, 2017

Collaborator

Hey @mathiasbynens! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

Collaborator

babel-bot commented Jan 20, 2017

Hey @mathiasbynens! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@mathiasbynens

This comment has been minimized.

Show comment
Hide comment
@mathiasbynens

mathiasbynens Jan 20, 2017

Contributor

Rebased again, and builds now pass.

Contributor

mathiasbynens commented Jan 20, 2017

Rebased again, and builds now pass.

@hzoo hzoo merged commit 090f7ab into babel:7.0 Jan 20, 2017

3 checks passed

codecov/patch Coverage not affected when comparing 1aa7a2a...d7ec839
Details
codecov/project 89.61% (+0.00%) compared to 1aa7a2a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment