New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable babel for tests #4564

Merged
merged 4 commits into from Oct 12, 2016

Conversation

Projects
None yet
2 participants
@danez
Member

danez commented Sep 25, 2016

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets
License MIT
Doc PR

This enables babel for tests by using a mocha compiler and it uses the babel config from package.json
I transformed OptionsManager test to es2015 to see if it works

Also removed the 5s timeout from cli tests, as the default timeout is already 10s, this should probably fix the timouts on travis that we had in babylon

Also run the cli tests on travis, they were disabled if istanbul is active, but istanbul is always active on travis so we were never running this tests. If they still timeout sometimes, we might need to investigate

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 25, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4564 into master will increase coverage by <.01%

@@             master      #4564   diff @@
==========================================
  Files           195        195          
  Lines         13774      13776     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3172       3173     +1   
==========================================
+ Hits          12226      12228     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update f9ccee9...70a0037

codecov-io commented Sep 25, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4564 into master will increase coverage by <.01%

@@             master      #4564   diff @@
==========================================
  Files           195        195          
  Lines         13774      13776     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3172       3173     +1   
==========================================
+ Hits          12226      12228     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update f9ccee9...70a0037

danez added some commits Sep 25, 2016

Enable babel for tests
This enables babel for tests by using a mocha compiler
It uses the babel config from package.json
Transformed OptionsManager test to es2015 to see if it works
Removed the 5s timeout from cli tests, as the default timeout is already 10s, this should probably fix the timouts on travis that we had in babylon
Also run the cli tests on travis, they were disabled if istanbul active, but istanbul is always active on travis so we were never running this tests.

@danez danez merged commit 1dca51f into master Oct 12, 2016

5 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing f9ccee9...70a0037
Details
codecov/project 88.76% (+<.01%) compared to f9ccee9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@danez danez deleted the tests-es2015 branch Oct 12, 2016

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Enable babel for tests (#4564)
* Enable babel for tests

This enables babel for tests by using a mocha compiler
It uses the babel config from package.json
Transformed OptionsManager test to es2015 to see if it works
Removed the 5s timeout from cli tests, as the default timeout is already 10s, this should probably fix the timouts on travis that we had in babylon
Also run the cli tests on travis, they were disabled if istanbul active, but istanbul is always active on travis so we were never running this tests.

* ignore scripts directory

* only register for tests

* Set only flag correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment