New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude super from being assign to ref variable #4642

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
3 participants
@danez
Member

danez commented Oct 2, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #4349
License MIT
Doc PR

Assigning of super is not allowed var ref = super; This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned to a variable.

Exclude super from being assign
Assigning of super is not allowed `var ref = super;` This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned.

@danez danez changed the title from Exclude super from being assign to Exclude super from being assign to ref variable Oct 2, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 2, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4642 into master will increase coverage by <.01%

@@             master      #4642   diff @@
==========================================
  Files           195        195          
  Lines         13775      13777     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3173       3174     +1   
==========================================
+ Hits          12227      12229     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update e50b3c8...d9dd01c

codecov-io commented Oct 2, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4642 into master will increase coverage by <.01%

@@             master      #4642   diff @@
==========================================
  Files           195        195          
  Lines         13775      13777     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3173       3174     +1   
==========================================
+ Hits          12227      12229     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update e50b3c8...d9dd01c

@hzoo hzoo merged commit 2dcee25 into babel:master Oct 4, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e50b3c8...d9dd01c
Details
codecov/project 88.76% (+<.01%) compared to e50b3c8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Exclude super from being assign (babel#4642)
Assigning of super is not allowed `var ref = super;` This fix adds an exception into
the explode helper so that super stays untouched and does not get assigned.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment