New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when constructor default arg refers to self or own static property #4666

Merged
merged 1 commit into from Oct 5, 2016

Conversation

Projects
None yet
4 participants
@danharper
Member

danharper commented Oct 4, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? yes
Fixed tickets #4253, #4442
License MIT
Doc PR reference to the documentation PR, if any

They currently throw Cannot call a class as a function due to being incorrectly wrapped in an IIFE.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 4, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4666 into master will increase coverage by <.01%

@@             master      #4666   diff @@
==========================================
  Files           195        195          
  Lines         13776      13782     +6   
  Methods        1425       1426     +1   
  Messages          0          0          
  Branches       3174       3176     +2   
==========================================
+ Hits          12228      12234     +6   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update fc54264...53426d2

codecov-io commented Oct 4, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4666 into master will increase coverage by <.01%

@@             master      #4666   diff @@
==========================================
  Files           195        195          
  Lines         13776      13782     +6   
  Methods        1425       1426     +1   
  Messages          0          0          
  Branches       3174       3176     +2   
==========================================
+ Hits          12228      12234     +6   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update fc54264...53426d2

@danez

danez approved these changes Oct 5, 2016

Awesome. Nice.

@hzoo hzoo merged commit 33eb56a into babel:master Oct 5, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing fc54264...53426d2
Details
codecov/project 88.76% (+<.01%) compared to fc54264
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment