New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain method return types on transform-es2015-classes (closes #4665) #4668

Merged
merged 1 commit into from Oct 4, 2016

Conversation

Projects
None yet
4 participants
@danharper
Member

danharper commented Oct 4, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #4665
License MIT
Doc PR reference to the documentation PR, if any

Re-attaches return types when converting ClassMethod to FunctionExpression.

Added tests for loose & spec class transforms, with normal output, flow-comments & flow-strip-types.

@danez

danez approved these changes Oct 4, 2016

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 4, 2016

Member

Hmm - overlooked obviously. 👍 😄

I wonder how we can prevent this issue from happening in the future? This is because babel.types constructor doesn't take in all fields and types wouldn't be in there. Would be nice if we had a way to lint that the information from the previous node wasn't carried over

Member

hzoo commented Oct 4, 2016

Hmm - overlooked obviously. 👍 😄

I wonder how we can prevent this issue from happening in the future? This is because babel.types constructor doesn't take in all fields and types wouldn't be in there. Would be nice if we had a way to lint that the information from the previous node wasn't carried over

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 4, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4668 into master will increase coverage by <.01%

@@             master      #4668   diff @@
==========================================
  Files           195        195          
  Lines         13776      13778     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3174       3174          
==========================================
+ Hits          12228      12230     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update fc54264...d1f93fc

codecov-io commented Oct 4, 2016

Current coverage is 88.76% (diff: 100%)

Merging #4668 into master will increase coverage by <.01%

@@             master      #4668   diff @@
==========================================
  Files           195        195          
  Lines         13776      13778     +2   
  Methods        1425       1425          
  Messages          0          0          
  Branches       3174       3174          
==========================================
+ Hits          12228      12230     +2   
  Misses         1548       1548          
  Partials          0          0          

Powered by Codecov. Last update fc54264...d1f93fc

@hzoo hzoo merged commit 7f772e9 into babel:master Oct 4, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing fc54264...d1f93fc
Details
codecov/project 88.76% (+<.01%) compared to fc54264
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment