New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect compilation of async iterator methods #4719

Merged
merged 1 commit into from Oct 14, 2016

Conversation

Projects
None yet
5 participants
@Jamesernator
Contributor

Jamesernator commented Oct 13, 2016

Q A
Bug fix? yes
Breaking change? yes for spec compliancy
New feature? no
Deprecations? no
Spec compliancy? yes
Tests added/pass? changed 3 tests for spec compliancy
Fixed tickets 4705
License MIT
Doc PR n/a

This pull request is to fix an issue with how async generators are implemented in methods/objects/state methods to actually result in correct behaviour (see #4705). This closes #4705.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 13, 2016

Current coverage is 88.83% (diff: 100%)

No coverage report found for master at 09f135f.

Powered by Codecov. Last update 09f135f...e046bb1

codecov-io commented Oct 13, 2016

Current coverage is 88.83% (diff: 100%)

No coverage report found for master at 09f135f.

Powered by Codecov. Last update 09f135f...e046bb1

@danez

danez approved these changes Oct 13, 2016

Nice catch, I'm not 100% into the async iteration transform, but this seems correct.

@hzoo hzoo merged commit dc4140d into babel:master Oct 14, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project 88.83% (+<.01%) compared to 1dca51f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 14, 2016

Member

cc @domenic (should of earlier)

Member

hzoo commented Oct 14, 2016

cc @domenic (should of earlier)

@domenic

This comment has been minimized.

Show comment
Hide comment
@domenic

domenic Oct 14, 2016

Seems good to me :)

domenic commented Oct 14, 2016

Seems good to me :)

chrisprice added a commit to chrisprice/babel that referenced this pull request Oct 18, 2016

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment