New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run ESLint on test files, and fix lint errors in test files. #4732

Merged
merged 1 commit into from Oct 15, 2016

Conversation

Projects
None yet
3 participants
@DrewML
Member

DrewML commented Oct 15, 2016

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets #4714
License MIT
Doc PR reference to the documentation PR, if any

Closes #4714. Updated ESLint globbing patterns in the makefile to run over test folders now under packages, in addition to src. Also ran --fix to autofix a bunch of errors, and manually fixed the few that aren't autofixable.

This change includes adding some globals new env (mocha) globals to be ignored in .eslintrc. I should note that this will treat those identifiers as globals in all files, not just test files. The alternative to this would be to drop a .eslintrc in every test directory, or add an ignore comment to the top of each test file, but that seems like it would be a pain longterm.

@DrewML DrewML changed the title from Run ESLint on test files, and fix lint errors in test files. Closes #4714 to Run ESLint on test files, and fix lint errors in test files. Oct 15, 2016

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 15, 2016

Current coverage is 88.81% (diff: 100%)

Merging #4732 into master will not change coverage

@@             master      #4732   diff @@
==========================================
  Files           195        195          
  Lines         13826      13826          
  Methods        1428       1428          
  Messages          0          0          
  Branches       3187       3187          
==========================================
  Hits          12280      12280          
  Misses         1546       1546          
  Partials          0          0          

Powered by Codecov. Last update fd218ab...68e8683

codecov-io commented Oct 15, 2016

Current coverage is 88.81% (diff: 100%)

Merging #4732 into master will not change coverage

@@             master      #4732   diff @@
==========================================
  Files           195        195          
  Lines         13826      13826          
  Methods        1428       1428          
  Messages          0          0          
  Branches       3187       3187          
==========================================
  Hits          12280      12280          
  Misses         1546       1546          
  Partials          0          0          

Powered by Codecov. Last update fd218ab...68e8683

Show outdated Hide outdated .eslintrc
'var x = function x(y) {',
' return y;',
'};'
"\"use strict\";",

This comment has been minimized.

@hzoo

hzoo Oct 15, 2016

Member

We can totally use template strings here (different pr)

@hzoo

hzoo Oct 15, 2016

Member

We can totally use template strings here (different pr)

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Oct 15, 2016

Member

Awesome this is great! First PR! 🎉

Member

hzoo commented Oct 15, 2016

Awesome this is great! First PR! 🎉

@hzoo hzoo merged commit c003822 into babel:master Oct 15, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing fd218ab...68e8683
Details
codecov/project 88.81% (+0.00%) compared to fd218ab
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

chrisprice added a commit to chrisprice/babel that referenced this pull request Oct 18, 2016

mstade added a commit to zambezi/babel that referenced this pull request Oct 28, 2016

Merge branch 'master' into umd-resolve-imports
* master: (38 commits)
  chore(package): update browserify to version 13.1.1 (#4762)
  Increase test coverage (#4742)
  Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (#4758)
  Add variance node type and generate property variance annotations (#4697)
  Add make command to delete node_modules (#4748)
  fixes [skip ci]
  Support ObjectExpression in static path evaluation (#4746)
  Fix replacing for-of if inside label (#4736)
  Replace `path-exists` with `fs.existsSync` (#4731)
  Avoid unnecessary +0 in transform-es2015-parameters (#4738)
  [import()] Initial support for dynamic-import (#4699)
  Fix line endings on checkout
  Automatically generate missing expected.js fixtures (#4735)
  Fix few typos in issue/pr templates (#4739) [skip ci]
  contributing updates [skip ci]
  increase git depth [skip ci]
  Change usage of "suite"/"test" in unit-tests to "describe"/"it" (#4734)
  Run ESLint on test files, and fix lint errors in test files (#4732)
  Add .gitattributes forcing LF line endings (#4730)
  Update tests for changed error messages in Babylon (#4727)
  ...

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment