Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change usage of "suite"/"test" in unit-tests to "describe"/"it" #4734

Merged
merged 1 commit into from Oct 15, 2016

Conversation

Projects
None yet
5 participants
@DrewML
Copy link
Member

commented Oct 15, 2016

Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets #4733
License MIT
Doc PR reference to the documentation PR, if any

Title should be self-explanatory. Note that this will fail linting in CI until #4732 is merged into master. This was a change suggested by @hzoo in #4733

@DrewML

This comment has been minimized.

Copy link
Member Author

commented Oct 15, 2016

Merge conflicts fixed

@codecov-io

This comment has been minimized.

Copy link

commented Oct 15, 2016

Current coverage is 88.81% (diff: 100%)

Merging #4734 into master will not change coverage

@@             master      #4734   diff @@
==========================================
  Files           195        195          
  Lines         13826      13826          
  Methods        1428       1428          
  Messages          0          0          
  Branches       3187       3187          
==========================================
  Hits          12280      12280          
  Misses         1546       1546          
  Partials          0          0          

Powered by Codecov. Last update c003822...6c2b4fa

@hzoo hzoo merged commit 9f8ab29 into babel:master Oct 15, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing c003822...6c2b4fa
Details
codecov/project 88.81% (+0.00%) compared to c003822
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danez

This comment has been minimized.

Copy link
Member

commented Oct 16, 2016

👍

@DrewML DrewML deleted the DrewML:issue4733 branch Oct 16, 2016

chrisprice added a commit to chrisprice/babel that referenced this pull request Oct 18, 2016

@@ -17,7 +17,7 @@ suite("babel-code-frame", function () {
].join("\n"));
});

test("optional column number", function () {
it("optional column number", function () {

This comment has been minimized.

Copy link
@lydell

lydell Oct 21, 2016

Contributor

I always thought that the function is called it to help writing sentences that describe the behavior. Like it('allows column numbers to be optional'). I kinda always cringe when people use it the test way, but whatever :)

mstade added a commit to zambezi/babel that referenced this pull request Oct 28, 2016

Merge branch 'master' into umd-resolve-imports
* master: (38 commits)
  chore(package): update browserify to version 13.1.1 (babel#4762)
  Increase test coverage (babel#4742)
  Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758)
  Add variance node type and generate property variance annotations (babel#4697)
  Add make command to delete node_modules (babel#4748)
  fixes [skip ci]
  Support ObjectExpression in static path evaluation (babel#4746)
  Fix replacing for-of if inside label (babel#4736)
  Replace `path-exists` with `fs.existsSync` (babel#4731)
  Avoid unnecessary +0 in transform-es2015-parameters (babel#4738)
  [import()] Initial support for dynamic-import (babel#4699)
  Fix line endings on checkout
  Automatically generate missing expected.js fixtures (babel#4735)
  Fix few typos in issue/pr templates (babel#4739) [skip ci]
  contributing updates [skip ci]
  increase git depth [skip ci]
  Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734)
  Run ESLint on test files, and fix lint errors in test files (babel#4732)
  Add .gitattributes forcing LF line endings (babel#4730)
  Update tests for changed error messages in Babylon (babel#4727)
  ...

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.