New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replacing for-of if inside label #4736

Merged
merged 1 commit into from Oct 17, 2016

Conversation

Projects
None yet
3 participants
@danez
Member

danez commented Oct 16, 2016

Q A
Bug fix? yes
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #3858
License MIT
Doc PR

This replaces the labeledStatement instead of the ForOfStatement itself as we already
integrate the label in the replacement nodes here: https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-es2015-for-of/src/index.js#L82..L84
Fixes #3858

Fix replacing for-of if inside label
This replaces the label instead of the for-of itself as we already
integrate the label in the replacement nodes.
Fixes #3858
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Oct 16, 2016

Current coverage is 88.82% (diff: 100%)

No coverage report found for master at 2dc919d.

Powered by Codecov. Last update 2dc919d...02e9112

codecov-io commented Oct 16, 2016

Current coverage is 88.82% (diff: 100%)

No coverage report found for master at 2dc919d.

Powered by Codecov. Last update 2dc919d...02e9112

@hzoo hzoo merged commit d9dd328 into babel:master Oct 17, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project 88.82% (+<.01%) compared to 9f8ab29
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

chrisprice added a commit to chrisprice/babel that referenced this pull request Oct 18, 2016

Fix replacing for-of if inside label (babel#4736)
This replaces the label instead of the for-of itself as we already
integrate the label in the replacement nodes.
Fixes babel#3858

mstade added a commit to zambezi/babel that referenced this pull request Oct 28, 2016

Merge branch 'master' into umd-resolve-imports
* master: (38 commits)
  chore(package): update browserify to version 13.1.1 (babel#4762)
  Increase test coverage (babel#4742)
  Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758)
  Add variance node type and generate property variance annotations (babel#4697)
  Add make command to delete node_modules (babel#4748)
  fixes [skip ci]
  Support ObjectExpression in static path evaluation (babel#4746)
  Fix replacing for-of if inside label (babel#4736)
  Replace `path-exists` with `fs.existsSync` (babel#4731)
  Avoid unnecessary +0 in transform-es2015-parameters (babel#4738)
  [import()] Initial support for dynamic-import (babel#4699)
  Fix line endings on checkout
  Automatically generate missing expected.js fixtures (babel#4735)
  Fix few typos in issue/pr templates (babel#4739) [skip ci]
  contributing updates [skip ci]
  increase git depth [skip ci]
  Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734)
  Run ESLint on test files, and fix lint errors in test files (babel#4732)
  Add .gitattributes forcing LF line endings (babel#4730)
  Update tests for changed error messages in Babylon (babel#4727)
  ...

panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017

Fix replacing for-of if inside label (babel#4736)
This replaces the label instead of the for-of itself as we already
integrate the label in the replacement nodes.
Fixes babel#3858
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment