Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ObjectExpression in static path evaluation #4746

Merged
merged 1 commit into from Oct 17, 2016

Conversation

motiz88
Copy link
Contributor

@motiz88 motiz88 commented Oct 17, 2016

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
License MIT

This gives babel-traverse the ability to statically evaluate simple object literals.

When this is released I will use it to implement istanbuljs/babel-plugin-istanbul#4 (comment), resolving #4740 (comment), allowing us to move forward with #4740 and get more useful code coverage reports.

cc @danez

@codecov-io
Copy link

codecov-io commented Oct 17, 2016

Current coverage is 88.81% (diff: 100%)

Merging #4746 into master will decrease coverage by 0.01%

@@             master      #4746   diff @@
==========================================
  Files           196        196          
  Lines         13838      13868    +30   
  Methods        1430       1430          
  Messages          0          0          
  Branches       3190       3198     +8   
==========================================
+ Hits          12293      12317    +24   
- Misses         1545       1551     +6   
  Partials          0          0          

Powered by Codecov. Last update d9dd328...05b9f3f

Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me. Might be also helpful for some stuff in babili @kangax @boopathi Although I see babili is already optimizing object expressions.

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Oct 17, 2016
@hzoo hzoo merged commit 6bc10b5 into babel:master Oct 17, 2016
motiz88 added a commit to motiz88/istanbul-lib-instrument that referenced this pull request Oct 17, 2016
…rumented file

In support of finally fixing istanbuljs/babel-plugin-istanbul#4.
Blocked on a babel-traverse release that includes babel/babel#4746
@kangax
Copy link
Member

kangax commented Oct 18, 2016

This looks awesome, definitely helpful for Babili. Thanks @motiz88

chrisprice pushed a commit to chrisprice/babel that referenced this pull request Oct 18, 2016
mstade added a commit to zambezi/babel that referenced this pull request Oct 28, 2016
* master: (38 commits)
  chore(package): update browserify to version 13.1.1 (babel#4762)
  Increase test coverage (babel#4742)
  Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758)
  Add variance node type and generate property variance annotations (babel#4697)
  Add make command to delete node_modules (babel#4748)
  fixes [skip ci]
  Support ObjectExpression in static path evaluation (babel#4746)
  Fix replacing for-of if inside label (babel#4736)
  Replace `path-exists` with `fs.existsSync` (babel#4731)
  Avoid unnecessary +0 in transform-es2015-parameters (babel#4738)
  [import()] Initial support for dynamic-import (babel#4699)
  Fix line endings on checkout
  Automatically generate missing expected.js fixtures (babel#4735)
  Fix few typos in issue/pr templates (babel#4739) [skip ci]
  contributing updates [skip ci]
  increase git depth [skip ci]
  Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734)
  Run ESLint on test files, and fix lint errors in test files (babel#4732)
  Add .gitattributes forcing LF line endings (babel#4730)
  Update tests for changed error messages in Babylon (babel#4727)
  ...
panagosg7 pushed a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: enhancement outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants