Chore: FLOW command in makefile and logic in .travis.yml(issue#4710). #4807

Merged
merged 1 commit into from Nov 4, 2016

Projects

None yet

3 participants

@sstern6
Contributor
sstern6 commented Nov 4, 2016
Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? no
Tests added/pass? yes
Fixed tickets #4710
License MIT
Doc PR reference to the documentation PR, if any

cc @hzoo -- Let me know if I missed anything or I need to add something.

Thanks!

@sstern6 sstern6 Chore: FLOW command in makefile and logic in .travis.yml(issue#4710).
6c6c9a8
@codecov-io
codecov-io commented Nov 4, 2016 edited

Current coverage is 89.30% (diff: 100%)

Merging #4807 into master will not change coverage

@@             master      #4807   diff @@
==========================================
  Files           196        196          
  Lines         13790      13790          
  Methods        1434       1434          
  Messages          0          0          
  Branches       3202       3202          
==========================================
  Hits          12315      12315          
  Misses         1475       1475          
  Partials          0          0          

Powered by Codecov. Last update b68e9bf...6c6c9a8

@hzoo hzoo added the tag: internal label Nov 4, 2016
- env: LINT=true
+ env:
+ - LINT: true
+ - FLOW: true
@hzoo
hzoo Nov 4, 2016 Member

Looks good only thing is whether we want to make the lint/flow separate runs or not @loganfsmyth @danez

@hzoo
hzoo Nov 4, 2016 edited Member

It does look like we are doing that in babylon https://github.com/babel/babylon/blob/master/.travis.yml#L31-L36

We can always change it later anyway

@hzoo hzoo merged commit 723ca0e into babel:master Nov 4, 2016

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing b68e9bf...6c6c9a8
Details
codecov/project 89.30% (+0.00%) compared to b68e9bf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hzoo
Member
hzoo commented Nov 4, 2016

Now to actually start turning on flow checking again on files!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment