Add another con 馃槥 #4927

Merged
merged 2 commits into from Dec 1, 2016

Projects

None yet

4 participants

@mischah
Contributor
mischah commented Dec 1, 2016
Q A
Bug fix? no
Breaking change? no
New feature? no
Deprecations? no
Spec compliancy? N/A
Tests added/pass? N/A
Fixed tickets N/A
License MIT
Doc PR yes
Dependency Changes no

Add another con against the usage of monorepos:
Lower ranking in npms results. At least until npms-io/npms-analyzer#83 is fixed.

Monorepos aren鈥檛 indexed equally because the API Responses from monorepos differs to the response from 禄normal芦 repos.

Compare the following two responses.

The github object is missing in case of monorepos.
This object contains properties like starsCount, forksCount, contributors, statuses and issues which influence all aspects of the npms ranking algorithm. See https://npms.io/about.

@mischah mischah Add another con 馃槥
c0af062
@codecov-io
codecov-io commented Dec 1, 2016 edited

Current coverage is 89.22% (diff: 100%)

No coverage report found for master at f71efbc.

Powered by Codecov. Last update f71efbc...c0af062

@hzoo
Member
hzoo commented Dec 1, 2016

Do we want to leave the ??? haha

@mischah mischah Bring back the ???
44ea70a
@mischah
Contributor
mischah commented Dec 1, 2016

Oops. I just brought them back.

Let me know if you want me to squash commits.

@hzoo
Member
hzoo commented Dec 1, 2016

Can just squash when merging

@hzoo hzoo merged commit 75720a3 into babel:master Dec 1, 2016

0 of 2 checks passed

ci/circleci CircleCI is running your tests
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@mischah mischah deleted the mischah:patch-1 branch Dec 1, 2016
@Daniel15
Member
Daniel15 commented Jan 3, 2017 edited

I'm surprised npms doesn't properly handle monorepos... I guess they're not as common in the JS world yet compared to other environments.

@panagosg7 panagosg7 added a commit to panagosg7/babel that referenced this pull request Jan 17, 2017
@mischah @panagosg7 mischah + panagosg7 monorepo doc: Add another con (#4927) [skip ci] 0eee4f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment