Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 0.10 support (CI) #5041

Merged
merged 3 commits into from Jan 20, 2017
Merged

Remove node 0.10 support (CI) #5041

merged 3 commits into from Jan 20, 2017

Conversation

@xtuc
Copy link
Member

@xtuc xtuc commented Dec 25, 2016

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? yes
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets Fixes #4315
License MIT
Doc PR no
Dependency Changes no

Related to #5025 (Drop support for Node 0.12 馃拃)

Dropping support is a breaking change, it will require a major release of Babel.

xtuc added 2 commits Dec 25, 2016
@xtuc xtuc added this to the Next Major milestone Dec 25, 2016
@xtuc xtuc added the area: tests label Dec 25, 2016
@codecov-io
Copy link

@codecov-io codecov-io commented Dec 25, 2016

Current coverage is 89.15% (diff: 100%)

Merging #5041 into master will not change coverage

@@             master      #5041   diff @@
==========================================
  Files           203        203          
  Lines          9821       9821          
  Methods        1072       1072          
  Messages          0          0          
  Branches       2614       2614          
==========================================
  Hits           8756       8756          
  Misses         1065       1065          
  Partials          0          0          

Powered by Codecov. Last update b2e6926...90279f1

@zertosh
Copy link
Member

@zertosh zertosh commented Dec 25, 2016

If node 4 is the new minimum, then node 0.12 should be dropped from .travis.yml too

@loganfsmyth
Copy link
Member

@loganfsmyth loganfsmyth commented Dec 25, 2016

Our concern is that while 0.10 is unsupported from the node devs, to me that doesn't necessarily mean that it's fine to drop support for it without a major version, since it's still a breaking change, even if the version that broke is outside the Node team's support range.

@xtuc
Copy link
Member Author

@xtuc xtuc commented Dec 26, 2016

@zertosh node 0.12 support is removed in the PR #5025 (.travis.yml updated)

@loganfsmyth It will of course require a major release. I added it to the milestone.

Copy link
Member

@existentialism existentialism left a comment

Small change to doc, but otherwise LGTM


The Babel compiler is **only** supported in these environments:

- Modern browsers such as Chrome, Firefox, Safari, Edge etc.
- Node 0.10+
- Node 4

This comment has been minimized.

@existentialism

existentialism Jan 15, 2017
Member

Nit: Node 4+ (Unlikely but people might interpret this as Node 4 only)?

This comment has been minimized.

@mathiasbynens

mathiasbynens Jan 15, 2017
Contributor

Since we鈥檙e nitpicking anyway: the proper name is 鈥淣ode.js鈥, not Node

@@ -17,7 +17,6 @@ to:
- Rhino
- Nashorn
- Internet Explorer

This comment has been minimized.

@xtuc

xtuc Jan 15, 2017
Author Member

I think that just "Internet Explorer" is vast (http://babeljs.io/docs/usage/caveats/#internet-explorer). Do you know which versions we could support officialy? Edge?

@hzoo hzoo changed the base branch from master to 7.0 Jan 20, 2017
@hzoo hzoo merged commit 2471d5e into babel:7.0 Jan 20, 2017
@xtuc xtuc deleted the xtuc:remove-0.10-support branch Jan 26, 2017
@lock lock bot added the outdated label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
You can鈥檛 perform that action at this time.