Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: plugin-transform-object-rest-spread param with default value #5088

Merged
merged 1 commit into from Jan 15, 2017

Conversation

Projects
None yet
5 participants
@christophehurpeau
Copy link
Contributor

commented Jan 10, 2017

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy?
Tests Added/Pass? yes
Fixed Tickets Fixes #4851
License MIT
Doc PR no
Dependency Changes

Fix when a parameter has a default object

@codecov-io

This comment has been minimized.

Copy link

commented Jan 10, 2017

Current coverage is 89.20% (diff: 100%)

Merging #5088 into master will increase coverage by <.01%

@@             master      #5088   diff @@
==========================================
  Files           203        203          
  Lines          9819       9822     +3   
  Methods        1071       1071          
  Messages          0          0          
  Branches       2615       2616     +1   
==========================================
+ Hits           8759       8762     +3   
  Misses         1060       1060          
  Partials          0          0          

Powered by Codecov. Last update 1ab58d6...4a19655

@christophehurpeau christophehurpeau referenced this pull request Jan 11, 2017

Closed

babel 6.20 #183

@loganfsmyth loganfsmyth force-pushed the christophehurpeau:fix-issue-4851 branch from acf2946 to 4a19655 Jan 15, 2017

@loganfsmyth loganfsmyth merged commit 7200626 into babel:master Jan 15, 2017

3 checks passed

codecov/patch 100% of diff hit (target 89.20%)
Details
codecov/project 89.20% (+<.01%) compared to 1ab58d6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@klimashkin

This comment has been minimized.

Copy link

commented Jan 16, 2017

@loganfsmyth Sorry for bothering. Is it for 7.x or there will be 6.x releases before?

@hzoo

This comment has been minimized.

Copy link
Member

commented Jan 16, 2017

6.x this week

@hzoo hzoo referenced this pull request Jan 19, 2017

Merged

object rest - fix when destructuring in variables/parameters #4755

7 of 7 tasks complete
@hzoo

This comment has been minimized.

Copy link
Member

commented Jan 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.