New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "class-constructor-call" syntax and transform plugins #5119

Merged
merged 2 commits into from Jan 20, 2017

Conversation

Projects
None yet
7 participants
@ColinRTaylor
Contributor

ColinRTaylor commented Jan 14, 2017

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? yes
Spec Compliancy? yes
Tests Added/Pass? yes
Fixed Tickets #5112
License MIT
Doc PR
Dependency Changes no

As described in #5112 this removes the class-constructor-call syntax and transform plugins and all references to them. It has been dropped by TC39.
I:

  1. Removed packages/babel-plugin-transform-class-constructor-call
  2. Removed packages/babel-plugin-syntax-class-constructor-call
  3. Remove the plugin from the stage-1 preset in both the package.json + main file
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Jan 14, 2017

@ColinRTaylor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @raspo to be potential reviewers.

@ColinRTaylor, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @existentialism and @raspo to be potential reviewers.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Jan 14, 2017

Current coverage is 89.19% (diff: 100%)

No coverage report found for 7.0 at 12886ea.

Powered by Codecov. Last update 12886ea...4ef7bfe

codecov-io commented Jan 14, 2017

Current coverage is 89.19% (diff: 100%)

No coverage report found for 7.0 at 12886ea.

Powered by Codecov. Last update 12886ea...4ef7bfe

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 14, 2017

Member

This is awesome! (can you also check/grep for "constructor call" in the codebase) there shouldn't be any maybe in the readme

Member

hzoo commented Jan 14, 2017

This is awesome! (can you also check/grep for "constructor call" in the codebase) there shouldn't be any maybe in the readme

@hzoo hzoo added this to the Babel 7 milestone Jan 14, 2017

@hzoo

hzoo approved these changes Jan 14, 2017

@ColinRTaylor

This comment has been minimized.

Show comment
Hide comment
@ColinRTaylor

ColinRTaylor Jan 14, 2017

Contributor

@hzoo the only other place that I am finding 'constructor call' is in the CHANGELOG.md

Contributor

ColinRTaylor commented Jan 14, 2017

@hzoo the only other place that I am finding 'constructor call' is in the CHANGELOG.md

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 14, 2017

Member

Cool must of removed it already then - will wait for another approval but thanks.

Hopefully we can get this all out soon

Member

hzoo commented Jan 14, 2017

Cool must of removed it already then - will wait for another approval but thanks.

Hopefully we can get this all out soon

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism

existentialism Jan 14, 2017

Member

I think we can also safely remove:

if (node.kind === "constructorCall") {

Member

existentialism commented Jan 14, 2017

I think we can also safely remove:

if (node.kind === "constructorCall") {

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 14, 2017

Member

cool haha yeah grep for the non space version to due using camelCase in js. constructor-call, constructorCall, constructor call

Member

hzoo commented Jan 14, 2017

cool haha yeah grep for the non space version to due using camelCase in js. constructor-call, constructorCall, constructor call

@ColinRTaylor

This comment has been minimized.

Show comment
Hide comment
@ColinRTaylor

ColinRTaylor Jan 15, 2017

Contributor

Thanks. I found one using camelCase it was in the file that @existentialism mentioned. It has been removed.

Contributor

ColinRTaylor commented Jan 15, 2017

Thanks. I found one using camelCase it was in the file that @existentialism mentioned. It has been removed.

@xtuc xtuc changed the title from Resolves #5112 to Remove "class-constructor-call" syntax and transform plugins Jan 15, 2017

@xtuc xtuc referenced this pull request in babel/website Jan 15, 2017

Closed

Remove "class-constructor-call" plugin #1137

ColinRTaylor added some commits Jan 14, 2017

@babel-bot

This comment has been minimized.

Show comment
Hide comment
@babel-bot

babel-bot Jan 20, 2017

Collaborator

Hey @ColinRTaylor! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

Collaborator

babel-bot commented Jan 20, 2017

Hey @ColinRTaylor! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time.

@danez

danez approved these changes Jan 20, 2017

@danez danez merged commit 1aa7a2a into babel:7.0 Jan 20, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment