Fixes #5108, browser.js and browser.js test removed #5124
Conversation
hzoo
added
the
PR: Breaking Change 💥
|
also cc @Daniel15 |
Current coverage is 89.62% (diff: 100%)
|
| @@ -1,112 +0,0 @@ | |||
| /* eslint max-len: 0 */ | |||
There was a problem hiding this comment.
There is also a reference to this file in package.json that we should delete now.
It'd also be great to move api/node.js to be index.js now that we don't have the split entry point.
There was a problem hiding this comment.
I've checked package.json but I haven't seen any mention of browser.js. Am I missing something or possibly looking in the wrong package.json ?
There was a problem hiding this comment.
Also could you elaborate on moving api/node.js to index.js? I tried a refactor/rename in associated files and unit tests but it lead to breaking build.
There was a problem hiding this comment.
Oh! I was totally wrong about the package.json point I made, sorry. I guess the code I was thinking of got removed a while ago.
Yeah, my proposal was to move api/node.js to index.js since that is one of the few places that loads it. I'd expect you to have to update a couple other references to load the index instead, but that seems fine?
There was a problem hiding this comment.
No problem and thanks for explaining 😄
| export { default as resolvePreset } from "./helpers/resolve-preset"; | ||
| export { version } from "../package"; | ||
|
|
||
| import * as util from "util"; |
There was a problem hiding this comment.
Looks like this is missing the ./
There was a problem hiding this comment.
Ahh, thanks for poiting this out, fixed.
There was a problem hiding this comment.
Also, not sure the "move" took hold, as it looks like api/node.js still exists?
Doesn't look like we need the api folder anymore either.
lock
bot
added
the
outdated
The files https://github.com/babel/babel/blob/master/packages/babel-core/src/api/browser.js and https://github.com/babel/babel/blob/master/packages/babel-core/test/_browser.js were not being used, thus this PR removes them.